Conversation
4 tasks
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-docs/pr/47/docs/iroh_docs/ Last updated: 2025-08-01T08:39:38Z |
ramfox
reviewed
Jul 30, 2025
src/engine.rs
Outdated
| }) | ||
| }) | ||
| } | ||
| // TODO(Frando): We can't port iroh-docs to 0.90 without something like this. |
Member
There was a problem hiding this comment.
hey, does this TODO need to be addressed before merging?
Member
Author
There was a problem hiding this comment.
I removed the comment. This is now just living elsewhere, as the needed iroh_blobs PR was merged.
ramfox
pushed a commit
to n0-computer/iroh-blobs
that referenced
this pull request
Jul 31, 2025
## Description This adds back a way to externally protect blobs from garbage collection. It works like it did in blobs1: Users can provide an (async) callback to which a `&mut HashSet<Hash>` is passed. The callback is invoked before each gc run, and all hashes added to the set will be protected from gc during this run. Used in n0-computer/iroh-docs#47 ## Breaking Changes <!-- Optional, if there are any breaking changes document them, including how to migrate older code. --> ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [ ] Self-review. - [ ] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant. - [ ] Tests if relevant. - [ ] All breaking changes documented.
Frando
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ports iroh-docs to iroh 0.91 and from quic-rpc to irpc.
TODOs / Missing features vs iroh-docs 0.35:
Doc::export_fileandDoc::import_fileare missing. Would need some more work to port them, I didn't get around to that yet. But it's not super critical, as you can import via iroh-blobs and then use Doc::set_hash.Status for everything else
Breaking Changes
Quite a few. TODO: Document.
Notes & open questions
Change checklist